[evolution-patches] Re: patch to fix #240762(widgets/menus)

[Li Yuan <Li Yuan Sun COM>]

I fixed #240762. But when Srinivasa fixed another bug (which do not have 
a bug id), he changed the same part of code and this  make
#240762 reproduce again. Now, this patch fixs above two bugs.

Kaushal Kumar wrote:

> On Tue, 2005-09-06 at 12:31 +0000, Li Yuan  wrote:
>  
>
> > Hi Kaushal,
> >
> > I have fixed #240762 earlier.
> >
> >    
> (http://cvs.gnome.org/viewcvs/evolution/widgets/menus/gal-define-views-dialog.c?r1=1.29&r2=1.30
>
>  
>
> <http://cvs.gnome.org/viewcvs/evolution/widgets/menus/gal-define-views-dialog.c?r1=1.29&r2=1.30>)
>  
>
> > For I didn't deal with the non-built-in part, Srinivasa made a patch
> >    
> to 
>  
>
> > fix it. 
> >
> >    
> (http://cvs.gnome.org/viewcvs/evolution/widgets/menus/gal-define-views-dialog.c?r1=1.32&r2=1.33
>
>  
>
> <http://cvs.gnome.org/viewcvs/evolution/widgets/menus/gal-define-views-dialog.c?r1=1.32&r2=1.33>)
>  
>
> > But the latter patch reproduce the bug. 
> >    
> You mean the bug did not get fixed fully? i.e. in which manner is the
> problem being reproduced? could you elaborate please. Do we have a filed
> bugzilla bug number?
>
>  
>
> > Now I have a new patch to fix 
> > this problem.
> > Please help me to review it.
> >    
> As per the patch, we would no more depend upon the check for built-in or
> non built-in items. I think this might affect the desired behavior.
> Srini: what is your opinion here?
>
> Thanks,
> Kaushal 
>