Re: [evolution-patches] [calendar] fix for #274188

["Chakravarthi P" <pchakravarthi novell com>]

sending revised patch with changes as suggested.

regards.

On Fri, 2005-09-09 at 22:31 +0000, chenthill(P Chenthill) wrote:
> On Thu, 2005-09-08 at 09:58 +0000, "Chakravarthi P"  wrote:
> > 93,10 @@ get_dtstart (ECalModel *model, ECalModel
> >                         } else
> >                                 tt_start = icaltime_from_timet
> > (comp_data->instance_start, tt_start.is_date);
> >                 }
> The right fix is  to change icaltime_from_timet  to
> icaltime_from_timet_with_zone since all days would not have a tzid
> associated with it.
> > +       
> > +               /* Make sure that the proper zone is set if priv has
> > the zone information */    
> > +               zone = priv->zone;
> > +               tt_start = icaltime_from_timet_with_zone
> > (comp_data->instance_start, tt_start.is_date, zone); 
> This is redundant.
> 
> thanks, Chenthill.
> 

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2802
diff -u -p -w -r1.2802 ChangeLog
--- ChangeLog	25 Aug 2005 10:26:27 -0000	1.2802
+++ ChangeLog	10 Sep 2005 07:30:58 -0000
@@ -1,3 +1,10 @@
+2005-09-10  P. S. Chakravarthi <pchakravarthi novell com>
+
+	Fix #274188
+	* gui/e-cal-model.c
+	(get_dtstart): make use of internal zone information so that
+	previous date is not shown in list view for an all-day event.
+
 2005-08-24  Chenthill Palanisamy  <pchenthill novell com>
 
 	Fixes #313705
Index: gui/e-cal-model.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-cal-model.c,v
retrieving revision 1.61
diff -u -p -w -r1.61 e-cal-model.c
--- gui/e-cal-model.c	24 Aug 2005 03:07:49 -0000	1.61
+++ gui/e-cal-model.c	10 Sep 2005 07:30:58 -0000
@@ -391,7 +391,8 @@ get_dtstart (ECalModel *model, ECalModel
 				if (priv->zone)
 					icaltimezone_convert_time (&tt_start, zone, priv->zone);
 			} else
-				tt_start = icaltime_from_timet (comp_data->instance_start, tt_start.is_date);
+				if (priv->zone)
+					tt_start = icaltime_from_timet_with_zone (comp_data->instance_start, tt_start.is_date, priv->zone);
 		}
 
 		if (!icaltime_is_valid_time (tt_start) || icaltime_is_null_time (tt_start))