Re: [evolution-patches] GroupWise Proxy - Modify Proxy Rights

[Shreyas Sriniavasan <sshreyas novell com>]

On Tue, 2005-09-06 at 11:05 +0530, Sankar P wrote:
> Hi,
> 
> Attached with this mail is the patch that alters the implementation of
> "modify proxy access rights", as per the latest SOAP schema. 
> 
> Will fix #311447. Please review.
> 
Couple of issues.

1) The changelog has two entries one of which seems to be about this
patch. 
The other changelog entry is misplaced.

2) e_gw_proxy_form_modify_proxy_msg (SoupSoapMessage *msg, proxyHandler
*new_proxy)
 {
        soup_soap_message_start_element (msg, "updates", NULL, NULL);
-
+       
+       soup_soap_message_start_element (msg, "delete", NULL, NULL);
+       soup_soap_message_end_element (msg);
+       
+       soup_soap_message_start_element (msg, "add", NULL, NULL);
        e_gw_proxy_form_soap_request_from_proxyHandler (msg, new_proxy);
+       soup_soap_message_end_element (msg);
 }
 
Kinda weird looking code, there are three soap start elements but only
two end elements.
Are we ending the "updates" element in someother place ? if then it
should probably be done
here, otherwise the function seems incomplete..

Cheers,
Shreyas