[evolution-patches] random crash-fix (camel-groupwise)



Hi,

The attached patch fixes the random crashes in groupwise, when
convert_to_calendar is called, and the variable 'tmp' remains
un-intialized. In those cases it used to crash while free'ing it.

I am not able to find a bug for it, but have seen the traces somewhere.

Thanks,
Vivek Jain

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/ChangeLog,v
retrieving revision 1.109
diff -u -p -r1.109 ChangeLog
--- ChangeLog	2 Sep 2005 08:55:43 -0000	1.109
+++ ChangeLog	6 Sep 2005 05:10:07 -0000
@@ -1,3 +1,9 @@
+2005-09-06 Vivek Jain <jvivek novell com>
+	
+	* camel-groupwise-folder.c :(convert_to_calendar)
+	initialize variable tmp, fixes random crash
+
 2005-09-02 Vivek Jain <jvivek novell com>
 	
 	* camel-groupwise-folder.c: (groupwise_folder_item_to_msg)
Index: camel-groupwise-folder.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/camel-groupwise-folder.c,v
retrieving revision 1.93
diff -u -p -r1.93 camel-groupwise-folder.c
--- camel-groupwise-folder.c	2 Sep 2005 08:55:43 -0000	1.93
+++ camel-groupwise-folder.c	6 Sep 2005 05:10:08 -0000
@@ -1928,7 +1928,7 @@ convert_to_calendar (EGwItem *item, char
 	GSList *attach_list = NULL;
 	GString *gstr = g_string_new (NULL);
 	int recur_key = 0;
-	char **tmp;
+	char **tmp = NULL;
 	const char *temp = NULL;
 
 	tmp = g_strsplit (e_gw_item_get_id (item), "@", -1);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]