[evolution-patches] Crash in imap using GSSAPI, but without a ticket or with an expired ticket: #317956
- From: Björn Torkelsson <torkel acc umu se>
- To: Evolution Patches <evolution-patches gnome org>
- Subject: [evolution-patches] Crash in imap using GSSAPI, but without a ticket or with an expired ticket: #317956
- Date: Sat, 08 Oct 2005 20:43:49 +0200
Attacthed patch fixes a crash in authenticating imap using GSSAPI with
an expired ticket or without a ticket. Bug number #317956.
The patch is against HEAD but should apply clean on the stable branch
too.
Please commit the patch if it is accepted. I don't have commit access.
/torkel
Index: camel/providers/imap/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/imap/ChangeLog,v
retrieving revision 1.37
diff -u -p -r1.37 ChangeLog
--- camel/providers/imap/ChangeLog 27 Sep 2005 12:22:12 -0000 1.37
+++ camel/providers/imap/ChangeLog 8 Oct 2005 18:25:26 -0000
@@ -1,3 +1,11 @@
+2005-09-27 Björn Torkelsson <torkel acc umu se>
+
+ ** See bug #317956.
+
+ * camel-imap-store.c:(try_auth): Null check sasl_resp
+ and bail out, otherwise evolution will crash when running strlen on
+ sasl_resp.
+
2005-09-27 Vivek Jain <jvivek novell com>
** See bug #315173.
Index: camel/providers/imap/camel-imap-store.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/imap/camel-imap-store.c,v
retrieving revision 1.331
diff -u -p -r1.331 camel-imap-store.c
--- camel/providers/imap/camel-imap-store.c 15 Sep 2005 17:59:15 -0000 1.331
+++ camel/providers/imap/camel-imap-store.c 8 Oct 2005 18:25:28 -0000
@@ -1232,7 +1232,7 @@ try_auth (CamelImapStore *store, const c
sasl_resp = camel_sasl_challenge_base64 (sasl, imap_next_word (resp), ex);
g_free (resp);
- if (camel_exception_is_set (ex))
+ if (!sasl_rest || camel_exception_is_set (ex))
goto break_and_lose;
response = camel_imap_command_continuation (store, sasl_resp, strlen (sasl_resp), ex);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]