[evolution-patches] Patch for 318227: Change LDAP search filter [mail/addressbook]
- From: "Carsten Guenther" <Carsten Guenther scalix com>
- To: evolution-patches gnome org
- Subject: [evolution-patches] Patch for 318227: Change LDAP search filter [mail/addressbook]
- Date: Fri, 7 Oct 2005 11:05:32 -0700
Attached patch fixes 318227. The LDAP search filter used was limited to
entries with objectclass "person" which prevented searching for
mailing-lists, a problem many people have. The patch changes the search
filter such that it looks for everything that has the attribute "mail"
set ("mail=*"). That's basically what Thunderbird and other clients do
as well.
I think bug 311884 still is valid but can be fixed t a later point.
Please review for commit to gnome-2-12 and head.
Thanks,
Carsten
? 318227.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/addressbook/ChangeLog,v
retrieving revision 1.310.2.1
diff -u -p -r1.310.2.1 ChangeLog
--- ChangeLog 4 Oct 2005 06:43:10 -0000 1.310.2.1
+++ ChangeLog 7 Oct 2005 17:57:53 -0000
@@ -1,3 +1,11 @@
+2005-10-07 Carsten Guenther <carsten guenther scalix com>
+
+ Fixes #318227
+
+ * backends/ldap/e-book-backend-ldap.c: Change ldap search filter
+ to include everything that has an email address. This will ensure
+ mailing-lists will be found as well.
+
2005-10-04 Sushma Rai <rsushma novell com>
* backends/ldap/e-book-backend-ldap.c: Added a mutext for ldap
Index: backends/ldap/e-book-backend-ldap.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/addressbook/backends/ldap/e-book-backend-ldap.c,v
retrieving revision 1.49.2.1
diff -u -p -r1.49.2.1 e-book-backend-ldap.c
--- backends/ldap/e-book-backend-ldap.c 4 Oct 2005 06:43:11 -0000 1.49.2.1
+++ backends/ldap/e-book-backend-ldap.c 7 Oct 2005 17:57:53 -0000
@@ -3250,7 +3250,7 @@ e_book_backend_ldap_build_query (EBookBa
else {
strings = g_new0(char*, 5);
strings[0] = g_strdup ("(&");
- strings[1] = g_strdup ("(objectclass=person)");
+ strings[1] = g_strdup ("(mail=*)");
strings[2] = data.list->data;
strings[3] = g_strdup (")");
retval = g_strjoinv (" ", strings);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]