Re: [evolution-patches] Patch for a crash on solaris

[Parthasarathi Susarla <sparthasarathi novell com>]

Look fine.

Cheers,
partha
On Thu, 2005-11-10 at 18:27 +0800, jeff cai wrote:
> Yes. If a temporay variable is introduced, it can be more efficient.
> Attached is new patch.
> 
> On Thu, 2005-11-10 at 15:09 +0530, Parthasarathi Susarla wrote:
> > I fell that it would better to use a variable (temporary) to store the
> > description string, and use it. 
> > Although am not sure how the compiler would optimise it though.
> > -partha
> > 
> > On Thu, 2005-11-10 at 17:33 +0800, jeff cai wrote:
> > > Hi
> > > Please review the patch.
> > > 
> > > On solairs, the parameter of printf can't be 'NULL',
> > > 
> > > for function camel_exception_get_description (ex), 
> > > when ex is 'NULL', the function also returns NULL.
> > > Therefore, evolution will crash. I add a condition choice
> > > to solve the problem.
> > > 
> > > Jeff Cai
> > > 
> > > _______________________________________________
> > > Evolution-patches mailing list
> > > Evolution-patches gnome org
> > > http://mail.gnome.org/mailman/listinfo/evolution-patches
> > 
> > _______________________________________________
> > Evolution-patches mailing list
> > Evolution-patches gnome org
> > http://mail.gnome.org/mailman/listinfo/evolution-patches