[evolution-patches] Patch for a crash on solaris
- From: jeff cai <Jeff Cai Sun COM>
- To: evolution-patches gnome org, Jeff Cai Sun COM
- Cc: sceri-evolution Sun COM
- Subject: [evolution-patches] Patch for a crash on solaris
- Date: Thu, 10 Nov 2005 17:33:11 +0800
Hi
Please review the patch.
On solairs, the parameter of printf can't be 'NULL',
for function camel_exception_get_description (ex),
when ex is 'NULL', the function also returns NULL.
Therefore, evolution will crash. I add a condition choice
to solve the problem.
Jeff Cai
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/imap/ChangeLog,v
retrieving revision 1.40
diff -u -r1.40 ChangeLog
--- ChangeLog 21 Oct 2005 07:09:11 -0000 1.40
+++ ChangeLog 10 Nov 2005 08:46:51 -0000
@@ -1,3 +1,8 @@
+2005-11-10 Jeff Cai <jeff cai sun com>
+
+ * camel-imap-store.c: (imap_auth_loop):
+ On solaris, the string parameter of g_strdup_printf can't be NULL.
+
2005-10-21 Shreyas Srinivasan <sshreyas novell com>
* camel-imap-utils.c:(imap_parse_list_response): Handle
Index: camel-imap-store.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/imap/camel-imap-store.c,v
retrieving revision 1.334
diff -u -r1.334 camel-imap-store.c
--- camel-imap-store.c 21 Oct 2005 05:26:46 -0000 1.334
+++ camel-imap-store.c 10 Nov 2005 08:47:02 -0000
@@ -1373,7 +1373,8 @@
errbuf = g_strdup_printf (_("Unable to authenticate "
"to IMAP server.\n%s\n\n"),
- camel_exception_get_description (ex));
+ camel_exception_get_description (ex) ?
+ camel_exception_get_description (ex) : "");
camel_exception_clear (ex);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]