Re: [evolution-patches] fix for #300891, e-d-s camel library i18n

[Not Zed <notzed ximian com>]

On Thu, 2005-05-12 at 19:52 +0900, Changwoo Ryu wrote:
> 2005-05-11 (수), 10:20 +0530, Not Zed 쓰시길:
> > 
> > I have one query about this patch, why do you deifne
> > CAMEL_EXPLICIT_TRANSLATION_DOMAIN and then just use GETTEXT_PACKAGE in
> > the provider file anyway?
> > 
> > Any particular reason?
>
> CAMEL_EXPLICIT_TRANSLATION_DOMAIN is for the _() marked strings (which
> are translated by the provider themselves).  And "translation_domain =
> GETTEXT_PACKAGE" setting is for the N_() marked strings in the
> provider/conf structs.

Umm, I KNOW that one is used by camel-provider, and the other isn't.  But why useGETTEXT_PACKAGE when you went to the trouble of definining the other one?

> > Otherwise it looks good.
> > 
> > On Sun, 2005-05-08 at 06:28 +0900, Changwoo Ryu wrote:
> > > Index: camel/providers/smtp/Makefile.am
> > > ===================================================================
> > > RCS
> > > file: /cvs/gnome/evolution-data-server/camel/providers/smtp/Makefile.am,v
> > > retrieving revision 1.20
> > > diff -u -p -r1.20 Makefile.am
> > > --- camel/providers/smtp/Makefile.am    2 Dec 2004 08:03:30
> > > -0000       1.20
> > > +++ camel/providers/smtp/Makefile.am    7 May 2005 21:17:13 -0000
> > > @@ -8,6 +8,7 @@ INCLUDES =                                      \
> > >         -I$(top_srcdir)/intl                    \
> > >         -I$(top_srcdir)/camel                   \
> > >         $(CAMEL_CFLAGS)                         \
> > > +       -DCAMEL_EXPLICIT_TRANSLATION_DOMAIN=
> > > \"$(GETTEXT_PACKAGE)\"      \
> > >         -DG_LOG_DOMAIN=\"camel-smtp-provider\"
> > >  
> > >  libcamelsmtp_la_SOURCES =                      \
> > > Index: camel/providers/smtp/camel-smtp-provider.c
> > > ===================================================================
> > > RCS
> > > file: /cvs/gnome/evolution-data-server/camel/providers/smtp/camel-smtp-provider.c,v
> > > retrieving revision 1.31
> > > diff -u -p -r1.31 camel-smtp-provider.c
> > > --- camel/providers/smtp/camel-smtp-provider.c  20 Sep 2004 05:59:54
> > > -0000      1.31
> > > +++ camel/providers/smtp/camel-smtp-provider.c  7 May 2005 21:17:13
> > > -0000
> > > @@ -57,6 +57,7 @@ camel_provider_module_init(void)
> > >         smtp_provider.authtypes = g_list_append
> > > (smtp_provider.authtypes, camel_sasl_authtype ("POPB4SMTP"));
> > >         smtp_provider.url_hash = camel_url_hash;
> > >         smtp_provider.url_equal = camel_url_equal;
> > > +       smtp_provider.translation_domain = GETTEXT_PACKAGE;
> > >