Re: [evolution-patches] Fixes #272005

[pchenthill <pchenthill novell com>]

Approved.

- Chenthill

On Thu, 2005-05-12 at 17:55 +0530, Shreyas wrote:
> Hey,
> 
> I have added action to the Help button so that the calender/ mail/ tasks
> help are launched depending on which component invokes the Send Options
> dialog. Also the modal issue is now fixed. Hope the patch is correct
> now :-).
> 
> Cheers,
> Shreyas
> 
> On Thu, 2005-05-12 at 12:26 +0200, Rodrigo Moya wrote:
> > On Thu, 2005-05-12 at 15:30 +0530, Shreyas wrote:
> > > Hey,
> > > 
> > > This fixes the "dialog closes" when Help button is clicked issue with
> > > Send Options Dialog. The patch does not associate any action with the
> > > Help button but changes the signal handling such that it does not close
> > > the Send Options dialog.
> > > 
> > we either remove the Help button or do something when the user presses
> > Help, but the way your patch works, although similar to the old one, is
> > not correct, IMO.
> > 
> > Also, the old dialog is modal, it seems, and the new one modeless.