Re: [evolution-patches] Exchange connector: Patch for #274066

[Not Zed <notzed ximian com>]

Note that e_notice is deprecated.  I'd like to remove it entirely by 2.4 if possible, for the e_error interface - which is more consistent/higgy.

And e-error should probably go into libedataserverui to facilitate this.


On Fri, 2005-05-06 at 15:56 +0530, Sarfraaz Ahmed wrote:
> Looks good for HEAD. Please add ChangeLog entry and commit.
>
> --Sarfraaz
>
> On Fri, 2005-05-06 at 10:48 +0530, Sushma Rai wrote:
> > Hi,
> > 
> > Even if the account was removed or disabled same warning message was
> > getting printed.
> > 
> > Please review.
> > -Sushma.
> > plain text document attachment (warn-account-disable-74066.diff)
> > Index: storage/exchange-config-listener.c
> > ===================================================================
> > RCS file: /cvs/gnome/evolution-exchange/storage/exchange-config-listener.c,v
> > retrieving revision 1.16
> > diff -u -p -r1.16 exchange-config-listener.c
> > --- storage/exchange-config-listener.c	28 Feb 2005 14:57:27 -0000	1.16
> > +++ storage/exchange-config-listener.c	26 Mar 2005 08:24:30 -0000
> > @@ -823,8 +823,14 @@ account_removed (EAccountList *account_l
> >  		priv->configured_name = NULL;
> >  	} else {
> >  		/* The account is in use. We can't remove it. */
> > -		e_notice (NULL, GTK_MESSAGE_INFO,
> > -			  _("The Exchange account will be removed when you quit Evolution"));
> > +		if (account->enabled) 
> > +			e_notice (NULL, GTK_MESSAGE_INFO,
> > +			  	_("The Exchange account will be removed when you quit Evolution"));
> > +		else {
> > +			/* account is disabled, not removed */
> > +			e_notice (NULL, GTK_MESSAGE_INFO,
> > +				_("The Exchange account will be disabled when you quit Evolution"));
> > +		}
> >  	}
> >  }
> >  
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches