Re: [evolution-patches] Re: [Evolution] Fixes bug #273868, #300113, #302831

[Not Zed <notzed ximian com>]

Shreyas,

What happened to the eds/camel fixes?

This stuff looks ok and should be committed, but aren't the others also needed?

 Michael


On Mon, 2005-05-09 at 12:32 -0400, Jeffrey Stedfast wrote:
> @@ -56,8 +57,10 @@ service_is_relevant (CamelService *servi
>         if (CAMEL_IS_DISCO_STORE (service) &&
>             camel_disco_store_status (CAMEL_DISCO_STORE (service)) ==
> CAMEL_DISCO_STORE_OFFLINE)
>                         return !going_offline;
> -
> +       else if ( CAMEL_IS_OFFLINE_STORE (service) && 
> +                 CAMEL_OFFLINE_STORE ( service )->state ==
> CAMEL_OFFLINE_STORE_NETWORK_UNAVAIL )
> +                               return !going_offline;
>         return service->status != CAMEL_SERVICE_DISCONNECTED;
>
> it'd be nice if you kept to the same coding style as the surrounding
> code (e.g. don't put the whitespace after the opening paren or before
> the close paren)
>
> other than that, this looks ok
>
> oh, also, this belongs on evolution-patches ximian com, not
> evolution ximian com
>
> Jeff
>
> On Mon, 2005-05-09 at 12:40 +0530, Shreyas wrote:
> > Hey,
> > 
> > The patch fixes a couple of issues related to Offline mode ( providers
> > which use Camel Offline Store ) and also removes the "Going Offline"
> > dialog as that blocks other operations while connections are being
> > dropped. The state change is being effectively handled by the offline/
> > online toggle icon which listens to the state change progress.  
> > 
> > Cheers,
> > Shreyas