Re: [evolution-patches] EDS camel-nntp-provider remove CAMEL_URL_ALLOW_PASSWORD

[Not Zed <notzed ximian com>]

On Thu, 2005-04-28 at 11:46 +0200, Alessandro Decina wrote:
> On gio, 2005-04-28 at 13:59 +0530, Not Zed wrote:
> > > /* if nessecary, prompt for the password */
> > > if (!service->url->passwd) {
> > > [cut]
> > > service->url->passwd = camel_session_get_password (session, service,
> > > NULL, prompt, "password", CAMEL_SESSION_PASSWORD_SECRET, ex);
> > > [cut]
> > 
> > Oh.  But that has zero to do with the CAMEL_URL_ALLOW_PASSWORD flag.
> Yes, I repeat: that flag is used ONLY by the camel-nntp-provider, and I
> see no point in this. All the other providers use the
> camel_session_get_password function to store the passwords.
>
> > > With that box shown, service->url->passwd is always set (possibily to
> > > "\0"). Without it, as it is required, the enter-password dialog is shown
> > > and service->url->passwd is set accordingly.
> > what "box" is it showing?  The password requester popup is not a "box"
> > and has nothing to do with setting the passwd. So, what "box" do you
> > mean?
> Well I was not clear.
> When the CAMEL_URL_ALLOW_PASSWORD is set, the account editor, in the
> Receiving Email tab, shows an input box to enter the password. That box
> IMO sould not be there.

Well it isn't there.  What version of evolution are you patching?  It definitely isn't here in 2.3.x.

That is why there is confusion here ...

I definitely do not see any such box.

> ALL the other providers use the camel session's get_password callback to
> ask the password. AFAIC in evolution that callback is hooked by the
> password request popup, and it HAS to do with setting the password.
>
> What I am saying is this: I think that the camel-nntp-provider simply
> should NOT show the password box in the account editor and only prompt
> for the password when and if required, just like all the rest of the
> providers do.
>
> Am I missing something?

I dont know, but I am, that box!