The patch will make the dialog modal to all Evolution windows. (From
gtk doc: Modal windows prevent interaction with other windows in the
same application.) Yes this might be a problem, but this is the current behavior of mail's advanced search dialog. So I think we need keep the same modality of the two dialogs. It is UI designer's call to decide whether make them both modal or non-modal. Harry JP Rosevear wrote: On Thu, 2005-03-24 at 11:42 -0500, Rodney Dawes wrote:Part of the patch is irrelevant to the fix and just makes whitespace changes. Does the change make the dialog modal to all Evolution windows, or only the one that it was opened from? It certainly would make sense to allow other Evolution windows to switch between components and folders I think. If the changes doesn't block other windows, I think it is OK to put in HEAD, and possibly even the branch. It's a minor bug fix, and not a major UI change that would break documentation. I am ok with it only going in HEAD as well.Hmm, now that you say this, the modality could be a problem - we already have other bugs where modality is screwing up stuff. -JP |