Re: [evolution-patches] Patch for solving problems after renaming a folder

[Sankar P <psankar novell com>]

The "folder_renamed" trigger is already set. The problem is due to not
updating the name in the camelfolder. The attached patch is updated as
per the review comments.

Thanks & Regards,
Sankar P

On Fri, 2005-03-18 at 12:47 +0530, Parthasarathi Susarla wrote:
> I think the idea is to trigger a "folder_renamed" event.
> You could explicltly trigger the event after the cache has been renamed.
> 
> Thanks,
> partha
> On Fri, 2005-03-18 at 14:34 +0800, Not Zed wrote:
> > 
> > ((CamelFolderClass *)parent_class)->rename()
> > 
> > is probably more readable.
> > 
> > Are you sure you want it to be invoked inside the cache lock?
> > 
> > On Thu, 2005-03-17 at 23:26 -0700, Pasupathilingam
> > Sankarasivasubramanian wrote: 
> > > Hi,
> > > 
> > > The attached patch will solve the following problems that occur on
> > > renaming a groupwise folder. camel-groupwise-folder file is updated.
> > > 
> > > 1) Shared-folder settings not visible on the properties dialog (bug
> > > #73800)
> > > 2) Folder name not getting refreshed properly in the properties dialog
> > > (bug #73676)
> > > 
> > > Regards,
> > > Sankar P

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/ChangeLog,v
retrieving revision 1.40
diff -u -p -r1.40 ChangeLog
--- ChangeLog	18 Mar 2005 06:01:55 -0000	1.40
+++ ChangeLog	18 Mar 2005 11:07:30 -0000
@@ -1,3 +1,10 @@
+2005-03-18  Sankar P <psankar novell com>
+
+	* camel-groupwise-folder.c: (groupwise_folder_rename)
+	Added code to complete the rename operation by updating the 
+        folder name and full name fields.
+	Fixes bugs 73800 and 73676	
+		
 2005-03-18  Vivek Jain <jvivek novell com>
 	
 	**Fixes bug #73458
Index: camel-groupwise-folder.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/camel-groupwise-folder.c,v
retrieving revision 1.41
diff -u -p -r1.41 camel-groupwise-folder.c
--- camel-groupwise-folder.c	18 Mar 2005 05:58:49 -0000	1.41
+++ camel-groupwise-folder.c	18 Mar 2005 11:07:31 -0000
@@ -435,7 +435,9 @@ groupwise_folder_rename (CamelFolder *fo
 	CAMEL_GROUPWISE_FOLDER_UNLOCK (folder, cache_lock) ;
 
 	camel_folder_summary_set_filename (folder->summary, summary_path) ;
-
+	
+	((CamelFolderClass * )parent_class)->rename(folder,new);
+	
 	state_file = g_strdup_printf ("%s/cmeta", folder_dir) ;
 	camel_object_set(folder, NULL, CAMEL_OBJECT_STATE_FILE, state_file, NULL) ;
 	g_free (state_file) ;