[evolution-patches] Re: Exchange connector - patch for setting OWA url path in editor.

["Ahmed Sarfraaz" <asarfraaz novell com>]

Looks fine, except for couple of minor things below.

>Index: exchange-account-setup.c
>===================================================================
>RCS file:
/cvs/gnome/evolution/plugins/exchange-account-setup/exchange-account-setup.c,v
>retrieving revision 1.13
>diff -u -p -r1.13 exchange-account-setup.c
>--- exchange-account-setup.c	17 Mar 2005 11:15:43 -0000	1.13
>+++ exchange-account-setup.c	18 Mar 2005 10:28:17 -0000
>@@ -396,12 +396,39 @@ destroy_label(GtkWidget *old, GtkWidget 
> 	gtk_widget_destroy(label);
> }
> 
>+static char *
>+construct_owa_url (CamelURL *url) 
>+{
>+	const char *owa_path = "/exchange", *use_ssl = NULL;
>+	const char *protocol = "http", *mailbox_name;
>+	char *owa_url;
>+
>+	use_ssl = camel_url_get_param (url, "use_ssl");
>+	if (use_ssl) {
>+		if (!strcmp (use_ssl, "always"))
>+			protocol = "https";
>+		else
>+			protocol = "http";
>
The else part is not needed as it is anyway the default value.

>+	}
>+
>+	owa_path = camel_url_get_param (url, "owa_path");
>
The previous owa_path value is getting lost here. Guess you wanted to
set it to "/exchange" only when get_param doesnt return a value.

>+	mailbox_name = camel_url_get_param (url, "mailbox");
>+
>
-- Sarfraaz