Re: [evolution-patches] patch for #73470 (exchange connector)



committed.

Siva
On Thu, 2005-03-10 at 11:30 +0530, Sushma Rai wrote:
> Looks fine.
> 
> Sivaiah Nallagatla wrote:
> 
> >Fixes 73470 and other similar ones .We are trying to free the vcard just
> >after adding it to list. We need not free it here. That list and cards
> >are freed elsewhere for sync backends.
> >
> >Siva
> >  
> >
> >------------------------------------------------------------------------
> >
> >Index: ChangeLog
> >===================================================================
> >RCS file: /cvs/gnome/evolution-exchange/ChangeLog,v
> >retrieving revision 1.289
> >diff -u -p -r1.289 ChangeLog
> >--- ChangeLog	9 Mar 2005 12:06:23 -0000	1.289
> >+++ ChangeLog	9 Mar 2005 12:12:46 -0000
> >@@ -1,4 +1,13 @@
> > 2005-03-09 Sivaiah Nallagatla <snallagatla novell com>
> >+
> >+	* addressbook/e-book-backend-exchange.c 
> >+	(e_book_backend_exchange_get_contact_list) : 
> >+	Don't free the vcard you just added to list !!!
> >+	That gets freed elsewhere.
> >+	Fixes #73470, #73030 #73025 and may be something 
> >+	else which i don't know
> >+
> >+2005-03-09 Sivaiah Nallagatla <snallagatla novell com>
> >                                                                                            
> >         * addresbook/e-book-backend-exchange.c
> >         (build_message) : make sure note is non NULL
> >Index: addressbook/e-book-backend-exchange.c
> >===================================================================
> >RCS file: /cvs/gnome/evolution-exchange/addressbook/e-book-backend-exchange.c,v
> >retrieving revision 1.22
> >diff -u -p -r1.22 e-book-backend-exchange.c
> >--- addressbook/e-book-backend-exchange.c	9 Mar 2005 12:06:24 -0000	1.22
> >+++ addressbook/e-book-backend-exchange.c	9 Mar 2005 12:12:47 -0000
> >@@ -1777,7 +1777,6 @@ e_book_backend_exchange_get_contact_list
> > 			if (!vcard)
> > 				continue;
> > 			*contacts = g_list_prepend (*contacts, vcard);
> >-			g_free (vcard);
> > 		}
> > 		status = e2k_result_iter_free (iter);
> > 
> >  
> >
> 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]