Re: [evolution-patches] Fix of lvalue cast in calendar-component.c for GCC4

[Rodrigo Moya <rodrigo novell com>]

On Wed, 2005-03-02 at 19:34 -0500, JP Rosevear wrote:
> On Wed, 2005-03-02 at 12:36 +0100, Rodrigo Moya wrote:
> > On Tue, 2005-03-01 at 20:29 -0500, David Malcolm wrote:
> > > Attached is a fix I had to apply to get Evolution 2.1.6 to build with
> > > GCC 4
> > > 
> > > Here's the error:
> > > calendar-component.c: In function 'popup_event_cb':
> > > calendar-component.c:562: error: invalid lvalue in assignment
> > > 
> > > The cast looks entirely redundant to me (since ecc_source_popups[0] is
> > > already an EPopupItem) and is potentially a bug if it implies creating a
> > > temporary EPopupItem and assigning to that - am I missing something?
> > > 
> > right, seems you're right, although I don't get that warning at all with
> > gcc 3.3.5. So, looks good to me if it fixes the warning to you
> 
> Should this be targetted at 2.2.0 or 2.2.1?
> 
I guess 2.2.0 if it's a build problem, right?
-- 
Rodrigo Moya <rodrigo novell com>