[evolution-patches] Fix of lvalue cast in calendar-component.c for GCC4
- From: David Malcolm <dmalcolm redhat com>
- To: Evolution Patches <evolution-patches ximian com>
- Subject: [evolution-patches] Fix of lvalue cast in calendar-component.c for GCC4
- Date: Tue, 01 Mar 2005 20:29:43 -0500
Attached is a fix I had to apply to get Evolution 2.1.6 to build with
GCC 4
Here's the error:
calendar-component.c: In function 'popup_event_cb':
calendar-component.c:562: error: invalid lvalue in assignment
The cast looks entirely redundant to me (since ecc_source_popups[0] is
already an EPopupItem) and is potentially a bug if it implies creating a
temporary EPopupItem and assigning to that - am I missing something?
Dave
--- evolution-2.1.6/calendar/gui/calendar-component.c.gcc4-fixes 2005-03-01 19:17:52.810097189 -0500
+++ evolution-2.1.6/calendar/gui/calendar-component.c 2005-03-01 19:19:41.793508389 -0500
@@ -559,7 +559,7 @@
group = e_source_selector_get_primary_source_group (selector);
g_object_ref (group);
- ((EPopupItem) ecc_source_popups [0]).user_data = group;
+ ecc_source_popups [0].user_data = group;
menus = g_slist_prepend (menus, &ecc_source_popups [0]);
}
else {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]