Re: [evolution-patches] Re: New hook for junk plugin (improved)

[Not Zed <notzed ximian com>]

One major problem!  check_junk() will always return false - you need to
get the return code from the plugin invoke and convert it to a boolean.

Otherwise, I guess it looks basically right.

Cheers,
 Michael

On Sat, 2005-06-25 at 19:59 +0530, Vivek Jain wrote:
> oops! just realized I had attached the wrong file.
> Here is the correct one.
> 
> On Sat, 2005-06-25 at 13:46 +0530, Vivek Jain wrote:
> > Hi NotZed,
> > 
> > Thanks a lot for the valuable comments. Following them I have much
> > improved the code now. Here I attach the improved "em-junk-hook.c" file
> > and improved patch to camel.
> > Now I:
> > 
> > 1. Have get_name function returning the name of plugin.
> > 2. Have check for the methods being supplied in construct_item
> > 3. Get only one item from the xml file
> > 4. Have cleaner way to use function pointers
> > 5. Have removed forward references at the top.
> > 
> > Please let me know if its suitable to be committed.
> > 
> > Thanks,
> > Vivek Jain
> > 
> > 
> > _______________________________________________
> > evolution-patches mailing list
> > evolution-patches lists ximian com
> > http://lists.ximian.com/mailman/listinfo/evolution-patches