Re: [evolution-patches] Bug 217540: Implementation of inline PGP receive support

[Not Zed <notzed ximian com>]

Hi Matt,

Had a quick look today, the code looks good.  I'll commit this sometime
this week & let you know.

Thanks,
 Michael

On Fri, 2005-06-24 at 21:25 +1200, Matt Brown wrote:
> Hi, 
> 
> Please find attached 3 patches to implement support for processing and
> displaying received inline PGP signed or encrypted messages. This is
> bounty #127521 and fixes bug #217540. I have chosen not to implement
> support for sending inline PGP messages, It's a pretty broken format and
> evo supports PGP/MIME I don't see any need for it.
> 
> The patches are as follow and can also be found at
> http://www.mattb.net.nz/patches/evolution/.
> 
> eds-inlinepgp-final.patch
> 
> Adds support to the backend to decrypt and verify inline PGP messages
> via two mime parts that are created by the inline-filter in the mailer.
> Also implements a camel-mime-filter to strip dash encoding from inline
> signed messages. 
> 
>  2005-06-24	Matt Brown <matt mattb net nz>
> 
> 	* camel-gpg-context.c:	Extend verify and decrypt functions to support
> 	inline pgp signed messages via x-inlinepgp-signed/x-inlinepgp-encrypted
> 	mime types.
> 	* camel-mime-filter-pgp.h:
> 	* camel-mime-filter-pgp.c:
> 	New filter to strip dash encoding from inline pgp signed messages.
> 
> 
> evo-inlinepgp-final.patch
> 
> Adds the necessary support to the mailer. 
> * Extends the inline filter to detect inline PGP message parts and
> creates the appropriate mime parts.
> * Implements format routines to pass the parts to the appropriate
> functions in the backend and display the verified/decrypted result. 
> 
> 2005-06-24	Matt Brown	<matt mattb net nz>
> 
> 	* em-inline-filter.c: implement extraction of inline signed/encrypted pgp
> 	parts and package them into x-inlinepgp-signed/x-inline-pgp-encrypted
> 	parts.
> 	* em-format-html.c: Formatters to verify/decrypt and then display the
> 	parts generated by the inline filter.
> 
> evo-inlinepgp-formatchanges.patch
> 
> Makes minor modifications to the way inline parts generated by the
> inline filter are displayed. Without this patch the generate mime parts
> for inline pgp messages display inside a grey border and do not appear
> as a normal main message. 
> 
> Michael Zucchi has expressed some reservations about this part of the
> patch, so I've seperated it out for ease of review. The full
> functionality of inline pgp support is provided without this patch, the
> display is just a little funny. 
> 
> Please apply these patches :)
> 
> They've been through several review cycles by Jeffrey Steadfast and
> Michael Zucchi on the -hackers mailing list so I'm hoping there are no
> remaining problems with them. 
> 
> Kind Regards
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches