Re: [evolution-patches] Improvements to the e-name-selector-entry
- From: Philip Van Hoof <spam pvanhoof be>
- To: Not Zed <notzed ximian com>
- Cc: evolution-patches lists ximian com, Sushma Rai <rsushma novell com>
- Subject: Re: [evolution-patches] Improvements to the e-name-selector-entry
- Date: Sun, 12 Jun 2005 11:53:26 +0200
Is this one approved?
On Wed, 2005-06-08 at 10:05 +0200, Philip Van Hoof wrote:
On Wed, 2005-06-08 at 10:31 +0800, Not Zed wrote:
> Well, it doesn't look too fine to me!
>
> Please, you must stick to the proper formatting and style. It is quite
> important although it doesn't seem like it.
>
> It is explained in some detail in the evolution/HACKING file. From
> various patches I've seen, I think it would be good for the bangalore
> team to review it if they haven't already.
Relax :)! It wasn't yet committed and still in pre-testing/mind-sharing
status. I attached a new version of the same patch with the two
coding-style problems removed.
Sushma Rai didn't yet review this version of the patch. And the (two)
coding-style errors weren't introduced in any previous version. He
didn't approve this version.
--
Philip Van Hoof, Software Developer @ Cronos
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.pvanhoof.be/
|
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]