Re: [evolution-patches] Improvements to the e-name-selector-entry

[Not Zed <notzed ximian com>]

Well, it doesn't look too fine to me!

Please, you must stick to the proper formatting and style.  It is quite
important although it doesn't seem like it.

It is explained in some detail in the evolution/HACKING file.  From
various patches I've seen, I think it would be good for the bangalore
team to review it if they haven't already.

Cheers,
 Michael

On Tue, 2005-06-07 at 11:29 +0530, Sushma Rai wrote:
> Looks fine for me.. Commit it to cvs head with the Changelog
> Also add a check for NULL EDestination.
> 
> It'll be easier to review patches if you use cvs diff with "-up"
> 
> Thanks,
> Sushma.
> 
> On Sun, 2005-06-05 at 12:16 +0000, Philip Van Hoof  wrote:
> > 
> > A small fix .. (use this version)
> > 
> > Perhaps I'll post more such fixes, in which case I'll increase the
> > number in the filename of the diff :-)
> > 
> > On Sun, 2005-06-05 at 14:03 +0200, Philip Van Hoof wrote:
> > > 
> > > Hi there,
> > > 
> > > 
> > > This patch will improve the e-name-selector-entry. 
> > > 
> > > This is the problem with current version (in HEAD):
> > > 
> > > When I type "Person a (found)" it means we have a EDestination with
> > > a name and an E-mail. When I type "Person a", it means we don't
> > > (it's just a name, it's not found in the list or it doesn't have a
> > > valid E-mail address).
> > > 
> > > At this moment, when you have this situation in your
> > > ENameSelectorEntry instance:
> > > 
> > > 
> > > "Person a (found), Person b ( found), Person c (found)"
> > > 
> > > And you remove the 3th ','-character. You'll get this:
> > > 
> > > "Person a (found), Person b Person c"
> > > 
> > > This one-character removal caused that two EDestination instances
> > > got invalid. Whereas the user probably wanted to just remove or
> > > correct the EDestination instance of "Person b (found)".
> > > 
> > > 
> > > Therefore I altered the behaviour a little bit. What will happen
> > > after this patch is
> > > 
> > > "Person a (found),
> > > Person b (found)
> > > , Person c (found)
> > > 
> > > ps. For people who don't have HTML E-mails: the entry in the middle
> > > has a blue background as in: it's selected
> > > 
> > > When you now press backspace or delete again, the selection will of
> > > course be removed. Like this:
> > > 
> > > "Person a (found),, Person c (found)"
> > > 
> > > So basically it means that the EDestination instance is cleared now.
> > > It still exists, but it's E-mail and Name are NULL.
> > > 
> > > If you now set your cursor like this
> > > 
> > > "Person a (found),,| Person c (found)"
> > > 
> > > And you press delete again, it will remove the EDestination instance
> > > from the model.
> > > 
> > > The user, however (and this is why it's not immediately removed),
> > > can also enter new EDestination information.
> > > 
> > > So this is the situation after the removal of the selected Person b
> > > (found):
> > > 
> > > "Person a (found),,| Person c (found)"
> > > 
> > > When the user starts pressing characters now, the entry will get
> > > completed (the combobox stuff) and the leftover EDestination will be
> > > formed again.
> > > 
> > > The result is, indeed, that you can very quickly remove lots of
> > > EDestinations from the list. Pressing backspace will remove entire
> > > EDestinations per keypress. Pressing BackSpace+DelKey will remove
> > > both the EDestination information and the EDestination instance from
> > > the model.
> > > 
> > > Yet the user gets warned about such a full deletion with the
> > > "Select" it, warning: You see, the EDestination in the entry gets
> > > selected first, then (after a new backspace/del keypress) removed.
> > > So there's visual feedback of what is going to happen.
> > > 
> > > 
> > > Anyway ... if you look at the patch: you'll notice it's more
> > > difficult to explain all this, then it was to code it. So my
> > > suggestion is, try it out! Compile the stuff in
> > > evolution-data-server/libedataserverui and launch the
> > > test-name-selector binary. You'll get two windows. A small one and a
> > > dialog. Use the small one to test this stuff.
> > > 
> > > 
> > > 
> > > -- 
> > > Philip Van Hoof, Software Developer @ Cronos
> > > home: me at pvanhoof dot be
> > > gnome: pvanhoof at gnome dot org
> > > work: philip dot vanhoof at cronos dot be
> > > junk: philip dot vanhoof at gmail dot com
> > > http://www.pvanhoof.be/
> > > _______________________________________________
> > > evolution-patches mailing list
> > > evolution-patches lists ximian com
> > > http://lists.ximian.com/mailman/listinfo/evolution-patches
> > -- 
> > Philip Van Hoof, Software Developer @ Cronos
> > home: me at pvanhoof dot be
> > gnome: pvanhoof at gnome dot org
> > work: philip dot vanhoof at cronos dot be
> > junk: philip dot vanhoof at gmail dot com
> > http://www.pvanhoof.be/
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches