RE: [evolution-patches] Patch for internationalisation incamel-provider.c

[Not Zed <notzed ximian com>]

On Wed, 2005-06-08 at 06:29 -0400, Ulrich Neumann wrote:
> The problem is that the domain entry is empty in the provider
> structure and 
> the field isn't filled in the particular providers like IMAP, POP3
> etc., 
> and the path to the mo files needs to be set with bindtextdomain
> somewhere. 

Well, they should be filled in then and set somewhere!

The exchange provider does it, I guess the others never did since they
were part of the evolution tree.

> That's what I did in order to get translated messages. These two lines
> were missing: 
>   bindtextdomain (GETTEXT_PACKAGE, CAMEL_LOCALEDIR); 
>   provider->translation_domain = (char *) GETTEXT_PACKAGE; 
>  
> Without this information the server tyoe and description is always
> displayed in english, 
> no matter what languange you want. 
>  
> If I misunderstand something here please let me know :-) 

No, sounds like its right on track.  If the bindtextdomain thing is all
that is needed, then that can just be done in camel_init() (they are all
camel providers afterall), and the translation_domain just needs to be
initialised in each provider.

(i guess the mail code already handles it).

Thanks,
 Michael
 
> Cheers 
>  
> Uli
> 
> >>>Not Zed <notzed ximian com> 06/08/05 4:22 am >>>
> 
> No, this merging is not necessary.  That is exactly why the provider
> structure provides the domain entry and bind's its text domain when it
> is created.
> 
> It just is a simple dgettext(s, prov->domain).
> 
> 
> On Tue, 2005-06-07 at 05:30 -0400, Ulrich Neumann wrote:
> >Hi,
> > 
> >but the account-editor is part of evolution, not e-d-s. The messages
> >are coming from
> >e-d-s and are stored in evolution-data-server-1.4.mo, not in
> >evolution-2.4.mo.
> > 
> >That's why I've put the patch in the e-d-s code and not in evolution.
> > 
> >Do you think it is wise to merge all the translations in one
> >single .mo file and have
> >all translations in evolution?
> > 
> >Cheers
> > 
> >Uli
> >
> >>>>"not zed" <notzed ximian com> 06/07/05 5:08 am >>>
> >
> >  
> >
> >
> >This is the wrong place to fix the translation, it should be done in
> >the account editor code, not here.
> >
> >  
> >
> >  
> >
> >-----Original Message-----
> >From: evolution-patches-bounces lists ximian com
> >[mailto:evolution-patches-bounces lists ximian com] On Behalf Of
> >Ulrich Neumann
> >Sent: Monday, 6 June 2005 10:20 AM
> >To: evolution-patches lists ximian com
> >Subject: [evolution-patches] Patch for internationalisation
> >incamel-provider.c
> >
> >  
> >
> >Hi, 
> >
> >
> >  
> >
> >
> >attached is a patch that fixes some translation issues in the account
> >properties pages. 
> >
> >
> >  
> >
> >
> >If this patch is OK, it would be great if someone can commit it,
> >because I have 
> >
> >
> >anon CVS access only. 
> >
> >
> >  
> >
> >
> >Cheers 
> >
> >
> >  
> >
> >
> >Uli 
> >
> >
> >
> >evolution-patches mailing list
> >evolution-patches lists ximian com
> >http://lists.ximian.com/mailman/listinfo/evolution-patches
> 
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches