Re: [evolution-patches] Account Editor: Fix for 307538



Probably add the provider != NULL check in the expression passed to the
function - so that the sensitivity is always set explictly, either on or
off.

i.e. first one:

e_account_writable(emae->account,
E_ACCOUNT_SENT_FOLDER_URI)&& !(emae->priv->source.provider->flags &
CAMEL_PROVIDER_DISABLE_SENT_FOLDER));

change to (something like ... i haven't checked the logic):

e_account_writable(emae->account, E_ACCOUNT_SENT_FOLDER_URI)
&& (emae->priv->source.provider == NULL
 || (emae->priv->source.provider->flags &
CAMEL_PROVIDER_DISABLE_SENT_FOLDER)));

Since you dont know the previous state/or can't rely on it.

On Thu, 2005-07-28 at 17:09 +0530, Shreyas wrote:
> Hey,
> 
> Attaching a patch which fixes the crash which happens when protocol is
> switched to None. Basically just adds a simple check on the protocol and
> does not sensitize widgets if its None.
> 
> Cheers,
> Shreyas
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]