[evolution-patches] Account Editor: Fix for 307538



Hey,

Attaching a patch which fixes the crash which happens when protocol is
switched to None. Basically just adds a simple check on the protocol and
does not sensitize widgets if its None.

Cheers,
Shreyas
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3664
diff -u -p -r1.3664 ChangeLog
--- ChangeLog	28 Jul 2005 06:45:05 -0000	1.3664
+++ ChangeLog	28 Jul 2005 10:36:42 -0000
@@ -1,3 +1,8 @@
+2005-07-28  Shreyas Srinivasan  <sshreyas novell com>
+
+	* em-account-editor.c (emae_defaults_page): Fix #307358. Check if
+	the provider type exists  before senisitizing widgets.
+	
 2005-07-28  Praveen Kumar <kpraveen novell com>
 
 	* em-account-editor.c (emae_check_complete) : Update the "Full Name" 
Index: em-account-editor.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-account-editor.c,v
retrieving revision 1.29
diff -u -p -r1.29 em-account-editor.c
--- em-account-editor.c	28 Jul 2005 06:45:06 -0000	1.29
+++ em-account-editor.c	28 Jul 2005 10:36:44 -0000
@@ -2141,11 +2141,14 @@ emae_defaults_page(EConfig *ec, EConfigI
 	emae_account_entry(emae, "bcc_addrs", E_ACCOUNT_BCC_ADDRS, xml);
 
 	gtk_widget_set_sensitive((GtkWidget *)gui->drafts_folder_button, e_account_writable(emae->account, E_ACCOUNT_DRAFTS_FOLDER_URI));
-	gtk_widget_set_sensitive((GtkWidget *)gui->sent_folder_button, e_account_writable(emae->account, E_ACCOUNT_SENT_FOLDER_URI)&& !(emae->priv->source.provider->flags & CAMEL_PROVIDER_DISABLE_SENT_FOLDER));
-	gtk_widget_set_sensitive((GtkWidget *)gui->restore_folders_button,
+
+	if (emae->priv->source.provider) {
+		gtk_widget_set_sensitive((GtkWidget *)gui->sent_folder_button, e_account_writable(emae->account, E_ACCOUNT_SENT_FOLDER_URI)&& !(emae->priv->source.provider->flags & CAMEL_PROVIDER_DISABLE_SENT_FOLDER));
+		gtk_widget_set_sensitive((GtkWidget *)gui->restore_folders_button,
 				 (e_account_writable(emae->account, E_ACCOUNT_SENT_FOLDER_URI) &&
 				   ! ( emae->priv->source.provider->flags & CAMEL_PROVIDER_DISABLE_SENT_FOLDER))
 				 || e_account_writable(emae->account, E_ACCOUNT_DRAFTS_FOLDER_URI));
+	}
 
 	/* Receipt policy */
 	emae_setup_receipt_policy (emae, xml);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]