Re: [evolution-patches] calendar, mail and exchange: patch for bug #231968

[Sarfraaz Ahmed <asarfraaz novell com>]

Hmm, found some more things which i should have pointed out in my 
earlier review :)

shakti wrote:

>Hi,
>  
>
> 
>Index: exchange-folder-permission.c
>===================================================================
>+	if (target->model)
>+		model = E_CAL_MODEL (target->model);
>+
>+	if (model)
>  
>
This check is not necessary. e_cal_model_get_default_client takes care 
of checking it for you.

>+		ecal = e_cal_model_get_default_client (model);
>+
>+	if (ecal)
>  
>
Similarly here too.

>+		uri = (gchar *) e_cal_get_uri (ecal);
>+
>+	if (uri && !g_str_has_prefix (uri, "exchange://"))
>+		return;
>+
>+	if (uri)
>  
>
This is not needed now.

>+		folder = exchange_account_get_folder (account, uri);
>+
>+	if (folder)
>  
>
We need to take care of removing this check for NULL folder here. 
Instead the public interface of 

exchange_permissions_dialog_new should check for a NULL account and
folder.

>+		exchange_permissions_dialog_new (account, folder, NULL);
> }
> 
>  
>
Similar changes will be needed in the remaining places as well.

Sorry for pointing this out late.
-- Sarfraaz