Re: [evolution-patches] calendar, mail and exchange: patch for bug #231968

[Sarfraaz Ahmed <asarfraaz novell com>]

Hi,

Some comments here for the exchange part.
> Index: ChangeLog
> 
> @@ -49,7 +50,11 @@ liborg_gnome_exchange_operations_la_SOUR
>  liborg_gnome_exchange_operations_la_LIBADD =           \
>         $(top_builddir)/e-util/libeutil.la                      \
>         $(top_builddir)/widgets/misc/libemiscwidgets.la         \
> +       $(top_builddir)/calendar/gui/libevolution-calendar.la \
> +       $(top_builddir)/mail/libevolution-mail.la \
> +       $(top_builddir)/addressbook/gui/component/libevolution-
> addressbook.la \
>         $(CAMEL_LIBS)                                           \
> +       $(EVOLUTION_MAIL_LIBS)                          \
> 
> You can remove the CAMEL_LIBS since EVOLUTION_MAIL_LIBS anyway
> includes them for us.
> 
>         $(CAMEL_EXCHANGE_LIBS)
>  
>  liborg_gnome_exchange_operations_la_LDFLAGS = -module -avoid-version
> Index: exchange-folder-permission.c
> 
> void
>  org_gnome_exchange_menu_cal_permissions (EPlugin *ep,
> ECalMenuTargetSelect *target)
>  {
> 
> +
> +       if (uri)
> +               folder = exchange_account_get_folder (account, uri);
> 
> Add one more check if the uri contains "exchange://"
> 
> +
>  void
>  org_gnome_exchange_menu_tasks_permissions (EPlugin *ep,
> ECalMenuTargetSelect *target)
>  {
> +       ExchangeAccount *account = NULL;
> +  
> 
> +       if (uri)
> 
> Here too ...
> 
> +               folder = exchange_account_get_folder (account, uri);
> +
> 
> 
>  void
>  org_gnome_exchange_menu_ab_permissions (EPlugin *ep,
> EABMenuTargetSelect *target)
>  {
> 
> +       if (uri)
> 
> Add a check here too ...
> 
> +               folder = exchange_account_get_folder (account, uri);
> +
> +       if (folder)
> +               exchange_permissions_dialog_new (account, folder,
> NULL);
>  }
> 
> 
> 
> 
> 

Thanks
-- Sarfraaz