Re: [evolution-patches] Evolution fix for #307794

[Harish <kharish novell com>]

On Tue, 2005-07-12 at 09:13 +0800, Not Zed wrote:
> Excuse me, but it doesn't look particularly good to me.
>
> It doesn't even include something I mentioned should be done; cleanup
> handling.  And apart from that it duplicates a whole bunch of code it
> shouldn't be.
Yes. I had noted that the patch requires rework. It duplicates about 10 lines
in a file of about 1500 lines - not that this would justify it though.
> Can you please explain what the hell is going on here?  Why are you
> approving patches which aren't up to scratch?
The underlying bug of the gtk combo box crash has prevented users from creating
new mail/calendar accounts for weeks together now (that includes distributions
that ship 2.3.x) - which means no new user could use evolution or add a new
account. I also observe that the kludge lies not in gtk+ but in the evo's code design
that allows a widget to be destroyed while in its signal handler.

With the 2.3.5 release hours away, I chose to take the patch in. It is not perfect but 
fixes the bug without breaking anything else. Treat this as CPR.  We'll swap as soon
as something better is available. 

Harish