Re: [evolution-patches] Evolution fix for #307794

[Not Zed <notzed ximian com>]

Excuse me, but it doesn't look particularly good to me.

It doesn't even include something I mentioned should be done; cleanup
handling.  And apart from that it duplicates a whole bunch of code it
shouldn't be.

Can you please explain what the hell is going on here?  Why are you
approving patches which aren't up to scratch?

On Mon, 2005-07-11 at 19:43 +0530, Harish wrote:
> Looks good to me. 
> 
> This has been a nasty bug and this patch is good enough.
> Pl. do commit it.
> PS. The idle handler is invoked exactly once. But it would run even if
> the 
> objects it manipulates may have been freed already. You could add some
> checks
> so it fails gracefully or better yet, remove the idle handler from
> executing
> (which could require a more complicated change).
> 
> Harish