Re: [evolution-patches] Proxy Login Patches

[Not Zed <notzed ximian com>]

I suggest these are just general permission bits, not with PROXY in the
name.

On Fri, 2005-07-08 at 16:06 +0530, Shreyas wrote:
> +/* a proxy store with mail read/write permissions*/
> +#define CAMEL_PROXY_STORE_READ  (1 << 13)
> +#define CAMEL_PROXY_STORE_WRITE (1 << 14) 

Also, they can probably start at bit 0, because the other bits are in
the 'flags' field, not the separate 'permissions' one, right?

Also, in the XML for the account, i'd probbly do something like:

<proxy uid="foo"/>

rather than:

<proxy>
  <parent-uid>foo</parent-uid>
</proxy>

The code is simpler, the xml is smaller and easier to read, etc.  (not a
major thing, but might be nice).

The rest looks ok. thanks.

Oh, account_can_send, leaks the store.

Do something like:

res = (store->permissions & CAMEL_STORE_WRITE) != 0;
camel_object_unref(store);

return res;


It could probably also check the id->address is set too rather than
having to check that manually everwhere you check if the account can
send.

 Michael