Re: [evolution-patches] "Forward" option in the command-line

[Not Zed <notzed ximian com>]

Almost there, but you have to use em_utils_forward_messages() instead of
forward_message - you can't call things like camel_folder_get_message
from the main thread (it could lock up the ui for an extended period
otherwise).  That function will then properly call the potentially
blocking camel functions.

Please commit once you've made this change - no need for another review
(just remember, create the ptrarray of uid's, copy the uid string, and
dont bother freeing any of it after calling the function).

Thanks,
 Michael

On Tue, 2005-07-05 at 14:54 +0530, Veerapuram Varadhan wrote:
> On Tue, 2005-07-05 at 13:17 +0800, Not Zed wrote:
> > The 'default' should just use the 'default' (i.e. what was being used
> > before), but you're overriding it to always use forward attached.
> Ah!! A very good point. Thanks.
> 
> > Looks good except for the default forward style.  Oh, and this is
> > external data - you really dont want to 'assert' on external data,
> > asserts are only used to assert internal conditions are met.
> > 
> > e.g. it should be a normal thing like:
> > 
> > if (uid == NULL)
> >   g_warning(...)
> > else {
> > }
> Hmm. Thanks.
> 
> Hope the attached one will make it to cvs. ;)
> 
> Let me know of any further suggestions/comments.
> 
> Thanks again,
> 
> V. Varadhan