Re: [evolution-patches] "Forward" option in the command-line

[Not Zed <notzed ximian com>]

On Mon, 2005-07-04 at 14:36 +0530, Veerapuram Varadhan wrote:
> On Mon, 2005-06-27 at 10:24 +0800, Not Zed wrote:
> > The style could use some work, see HACKING. In particular note the line
> > 'copy surrounding code'.
> > 
> Hmm.. read through those lines.  Hope the attached patch adhere to it.

Much better thanks.

> > Also, we really dont want to override the default forwarding style
> > because of some external application!  Definitely dont set any gconf
> > settings here!!!  Use the proper forwarding apis.
> > 
> It is still "evolution" that overrides the default forwarding style,

Umm, where?  Your patch added that.

> however, I have modified the patch according to your suggestion to use
> the proper forwarding APIs.

The 'default' should just use the 'default' (i.e. what was being used
before), but you're overriding it to always use forward attached.

> The command-line option and its parameter values remains same.
> 
> Let me know your further comments/suggestions about/on the patch.

Looks good except for the default forward style.  Oh, and this is
external data - you really dont want to 'assert' on external data,
asserts are only used to assert internal conditions are met.

e.g. it should be a normal thing like:

if (uid == NULL)
  g_warning(...)
else {
}


> Thanks,
> 
> V. Varadhan
> 
> > On Fri, 2005-06-24 at 22:37 +0530, Veerapuram Varadhan wrote:
> > > Hi,
> > > 
> > > Attached patch adds the ability to "forward" a mail from command-line
> > > like "reply".
> > > 
> > > The new parameter takes the following values:
> > > "quoted"
> > > "inline"
> > > "attached"
> > > 
> > > The command-line syntax is:
> > > evolution
> > > 'email://1118659289 31725 12 vvaradhan-test/Calendar;uid=424;forward=quoted'
> > > 
> > > The default value is "attached".
> > > 
> > > Kindly let me know your comments/suggestions.
> > > 
> > > Thanks,
> > > 
> > > V. Varadhan
> > > _______________________________________________
> > > evolution-patches mailing list
> > > evolution-patches lists ximian com
> > > http://lists.ximian.com/mailman/listinfo/evolution-patches
> >