Re: [evolution-patches] Patches to fix bug 309079



Hi, Harish.

On Fri, 2005-01-07 at 09:54 +0530, Harish Krishnaswamy wrote:
>  The patch looks good except for the fact that apart from the uid,
> string, list and query are also being leaked there (whenever they
> might have been assigned). Plus the styling and casting issues which
> Not Zed has already pointed out.

I'll admit that I didn't check for other potential memory issues while I
was in that code, as my focus was on getting gnome-pilot up and running
again. Sorry about that.

> Since the patch is just a few lines, I take the liberty to
> add the changes to the patch and commit them on your behalf.

Thank you. Will you also be closing bug #309079, or shall I?

//Mark





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]