Re: [evolution-patches] Patches to fix bug 309079

[Harish Krishnaswamy <kharish novell com>]

hi,

 The patch looks good except for the fact that apart from the uid,
string, list and query are also being leaked there (whenever they
might have been assigned). Plus the styling and casting issues which
Not Zed has already pointed out.

Since the patch is just a few lines, I take the liberty to
add the changes to the patch and commit them on your behalf.



-harish



On Thu, 2005-06-30 at 23:41 -0400, Mark G. Adams wrote:
> On Fri, 2005-01-07 at 00:11 +0800, Not Zed wrote:
> > Minor things - use k&r style braces (it is explained in HACKING), and
> > you dont need to cast to GObject anymore for g_object_unref, it takes a
> > void * (this isn't a problem; just a suggestion).
> 
> Noted, thank you for the review.
> 
> > Can you commit?  If so, fix those and go for it, otherwise someone
> > whomever commits it can fix them (no need to send a new patch).
> 
> No I'm not set up for GNOME CVS access, so I'll need somebody else to do
> the commit.
> 
> //Mark
> 
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches