Re: [evolution-patches] Mailer Context Menus Patch

[Not Zed <notzed ximian com>]

Instead of using separate arguments for boolean variables to the popup function, you should add new flags to em-popup, and control it that way.  You shouldn't need to create three separate popup lists at all, it can all be controlled via the flags on the one list, and that gives the same capabilities to all plugins, otherwise they will not have access to these differentiators - particularly since the menu is given the same id in all cases.

On Tue, 2005-01-25 at 17:59 -0500, Rodney Dawes wrote:
> Here is an updated version of the mailer context menus patch. It
> compresses a bit of the code into the emfv_popup routine, and
> pulls out a few "features", namely "View Source" and "Select All".
> This applies against HEAD, builds without warnings, and everything
> works.
>
> I will be pushing for UI freeze exception for this patch, but it
> is best we work out all the internal disagreements here first, and
> get to some final agreement on what it should be.
>
> -- dobey