Re: [evolution-patches] patch for #70339 (contacts)
- From: Sivaiah Nallagatla <snallagatla novell com>
- To: Hans Petter Jansson <hpj ximian com>
- Cc: patches <evolution-patches lists ximian com>
- Subject: Re: [evolution-patches] patch for #70339 (contacts)
- Date: Thu, 27 Jan 2005 19:18:45 -0800
On Wed, 2005-01-26 at 23:50 -0600, Hans Petter Jansson wrote:
> On Wed, 2005-01-26 at 23:27 -0800, Sivaiah Nallagatla wrote:
> > This match makes the search for "BEGIN:VCARD", "END:VCARD" in the vcard
> > string case insensitive. Though standars seems say that they must be in
> > uppercase it seems some apps send them in lowercase and most apps accept
> > it.
>
> Please use g_ascii_strcasecmp () as NotZed mentioned, plus I'd feel a
> lot better if you renamed strstrcase to eab_strstrcase in case there's a
> namespace conflict on some platform.
Made all the suggested changes and committed to both branches
Siva
> Otherwise ok.
>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]