Re: [evolution-patches] Patch for #71774

[Not Zed <notzed ximian com>]

Hi Mengjie,

I suggest you just move the second case to the top, that will avoid testing for NULL twice.

i.e.:

		if (strchr(new_name, '/') != NULL) {
			e_error_run((GtkWindow *)gtk_widget_get_toplevel((GtkWidget *)emft),
				    "mail:no-rename-folder", name, new_name, _("Folder names cannot contain '/'"), NULL);
			done = TRUE;
		} else if (new_name == NULL || !strcmp (name, new_name)) {
			/* old name == new name */
			done = TRUE;
		} else {

change to ->

    if (new_name == NULL || !strcmp()) {
       ...
   } else if (strchr(new_name, '/') ...) {
   }

And then please commit.

Thanks,
 Michael


On Wed, 2005-01-26 at 18:44 +0800, Mengjie Yu wrote:
> hi, Not Zed
>
> Here is the patch for #71774
>
> Will you please help me to review it?
>
> Thanks a lot.
>
> Yours,
> Mengjie