Re: [evolution-patches] Overwriting files warnings in save-attachments and save-calendar plugins



On Mon, 2004-12-27 at 23:57 +0100, Philip Van Hoof wrote:
> Oeps
> 
> Some small code-style fixes
> 
> 
looks good, only this:

> +       if (access (save, F_OK)) {
> +               GtkWidget *warning = 
> +                       gtk_message_dialog_new_with_markup (NULL,
> +                               GTK_DIALOG_DESTROY_WITH_PARENT,
> +                               GTK_MESSAGE_WARNING,
> +                               GTK_BUTTONS_NONE,
> +                               _("<b>A file %s already exists.</b>\n"
> +                                 "If you choose to overwrite this
> file, "
> +                                 "the contents will be lost."),
> save);
> 
it would be better to use here the same string than the mail is using
-> 
"File exists "%s".
Do you wish to overwrite it?"

The rest looks ok, so please just change that string and commit.
-- 
Rodrigo Moya <rodrigo novell com>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]