Re: [evolution-patches] Patch for #72545

[Not Zed <notzed ximian com>]

Ok, sounds fair.  Reverted.

On Fri, 2005-02-25 at 12:10 -0500, Rodney Dawes wrote:
> Well, I guess the menus might work. I didn't test the patch really.
> Hrmm. When I tested focus in the GtkEntry for the quick search, by
> typing some text into it, and opening a menu, yesterday on my desktop
> machine at the office, the cursor was no longer visible in the entry.
> However, I just tried again on my laptop, and it works fine. Weird.
>
> When I got the bug mail this morning from the bug being closed, I opened
> it up to re-open the bug, as I thought I had already moved it to the 2.3
> milestone and mentioned the new menu layout. Apparently I had not.
> However, looking at the bug more deeply, this doesn't really solve the
> issues presented in it. The patch doesn't move the menu item in the XML
> so that it shows up in the external mail display window. And given that
> it changes the behavior to be based on what is focused in the UI, it
> makes the usage of the Select All item even more confusing, and changes
> the expected behavior. Many people seem to rely on the C-a behavior
> working wherever the focus is. This patch makes it much harder to delete
> all mails that are the result of a search query for example. I think a
> patch that requires such functionality breaks UI freeze, and also would
> then require release-team approval. Let's just revert it, and fix it
> right in 2.3. Thanks.
>
> -- dobey
>
> On Fri, 2005-02-25 at 17:08 +0800, Not Zed wrote:
> > 
> > Rodney,
> > 
> > Given the time-zone issues, I've just told Mengjie to commit this on
> > irc.  If you can demonstrate that it really is an issue we can just
> > easily revert it ("better to ask for forgiveness than permission",
> > etc.).
> > 
> > Cheers,
> > Michael