Re: [evolution-patches] Patch for #72545

[Not Zed <notzed ximian com>]

Rodney,

Given the time-zone issues, I've just told Mengjie to commit this on irc.  If you can demonstrate that it really is an issue we can just easily revert it ("better to ask for forgiveness than permission", etc.).

Cheers,
 Michael


On Fri, 2005-02-25 at 16:13 +0800, Mengjie Yu wrote:
> hi, Not Zed
>
> So may I commit this patch ??
>
> Yours,
> Mengjie
>
> On Fri, 2005-02-25 at 11:33 +0800, Not Zed wrote:
> > 
> > Why wouldn't this work?  We do this in quite a few other places for
> > bonobo menu's.  It doesn't change focus when you activate the main
> > menus.
> > 
> > e.g. cut and copy do precisely this.
> > 
> > 
> > On Thu, 2005-02-24 at 12:23 -0500, Rodney Dawes wrote: 
> > > Please don't commit this. It doesn't solve the problem. It in fact,
> > > makes the Select All behavior even more confusing, because now there
> > > are 3 widgets that would all have "Select All" work for them. But,
> > > since you are checking for GTK_WIDGET_HAS_FOCUS() how does this work
> > > with the menuitem, since opening a menu, steals focus? If you type stuff
> > > in the quick search entry, and open the menu, the cursor disappears from
> > > the entry widget, so where did the focus go now? This will be solved
> > > more appropriately in 2.3 with better menu layout.
> > > 
> > > -- dobey
> > > 
> > > On Thu, 2005-02-24 at 19:06 +0800, Mengjie Yu wrote:
> > > > hi, Not Zed
> > > > 
> > > > Here is the patch for #72545
> > > > the related URL is:
> > > > http://bugzilla.ximian.com/show_bug.cgi?id=72545
> > > > 
> > > > Will you please help me to review it?
> > > > 
> > > > Thanks a lot.
> > > > 
> > > > Yours,
> > > > Mengjie
> > >