Re: [evolution-patches] Fix for 72676 (Saved filter rule can't be modified if it is selected with GOK)

[Harry Lu <Harry Lu Sun COM>]

No, please look at the bug comments in bugzilla.
The row is specified in the passing GtkTreePath. We just need to get the correct value for re->current from tree model.

Patch committed into CVS HEAD. Thanks!
��� Harry

Not Zed wrote:

Hmm, isn't this just a bug in gok?� If it's sending a double-click event WITHOUT the specific row being passed in?

Otherwise, sure I guess it looks ok.

Michael

On Thu, 2005-02-17 at 16:47 +0800, Harry Lu wrote:

 Hi, NotZed, 
     Here is a patch for 72676. 
 http://bugzilla.ximian.com/show_bug.cgi?id=72676 

     Please review it. 
     Thanks! 
        Harry 
    

text/plain attachment (filter.diff)

 Index: ChangeLog 
 =================================================================== 
 RCS file: /cvs/gnome/evolution/filter/ChangeLog,v 
 retrieving revision 1.422 
 diff -u -r1.422 ChangeLog 
 --- ChangeLog	10 Feb 2005 05:34:03 -0000	1.422 
 +++ ChangeLog	17 Feb 2005 08:43:07 -0000 
 @@ -1,3 +1,10 @@ 
 +2005-02-17  Harry Lu  <harry lu sun com> 
 + 
 +	Fix for 72676. 
 + 
 +	* rule-editor.c: (double_click): call gtk_tree_selection_get_selected 
 +	to see if there is a row selected. 
 + 
  2005-02-09  Hans Petter Jansson  <hpj novell com> 
   
  	* Makefile.am: Install shared libraries in privlibdir. 
 Index: rule-editor.c 
 =================================================================== 
 RCS file: /cvs/gnome/evolution/filter/rule-editor.c,v 
 retrieving revision 1.62 
 diff -u -r1.62 rule-editor.c 
 --- rule-editor.c	17 Jun 2004 07:34:07 -0000	1.62 
 +++ rule-editor.c	17 Feb 2005 08:43:20 -0000 
 @@ -546,6 +546,14 @@ 
  static void 
  double_click (GtkTreeView *treeview, GtkTreePath *path, GtkTreeViewColumn *column, RuleEditor *re) 
  { 
 +	GtkTreeSelection *selection; 
 +	GtkTreeModel *model; 
 +	GtkTreeIter iter; 
 +	 
 +	selection = gtk_tree_view_get_selection (re->list); 
 +	if (gtk_tree_selection_get_selected (selection, &model, &iter))  
 +		gtk_tree_model_get (GTK_TREE_MODEL (re->model), &iter, 1, &re->current, -1); 
 + 
  	if (re->current) 
  		rule_edit ((GtkWidget *) treeview, re); 
  }