Re: [evolution-patches] Patch to fix scrollbar policy in mail/




It is done this way on purpose, otherwise gtkhtml has to re-calculate and re-render almost every single email since the window size changes as it incrementally renders the display.

I highly recommend against this change.

Looking at cvs annotate for this line of code:
1.2          (zucchi   17-Sep-03): /* currently: just use a scrolledwindow for preview widget */
1.2          (zucchi   17-Sep-03): p->preview = gtk_scrolled_window_new(NULL, NULL);
1.13         (rodo     07-Jan-04): gtk_scrolled_window_set_policy((GtkScrolledWindow *)p->preview, GTK_POLICY_AUTOMATIC, GTK_POLICY_ALWAYS);
1.2          (zucchi   17-Sep-03): gtk_scrolled_window_set_shadow_type((GtkScrolledWindow *)p->preview, GTK_SHADOW_IN);
1.2          (zucchi   17-Sep-03): gtk_widget_show(p->preview);

then looking at the commit entry for revision 1.13:
revision 1.13
date: 2004/01/07 15:58:45;  author: rodo;  state: Exp;  lines: +1 -1
2004-01-07  Radek Doulik  <rodo ximian com>

* em-message-browser.c (emmb_init): as below

* em-folder-browser.c (emfb_init): always show vertical scrollbar,
we do the same for message list and it avoids ugly flicker

clearly shows why this is done like it is.

On Mon, 2005-02-14 at 13:47 -0500, Rodney Dawes wrote:
This patch fixes the scrollbar policy in the mailer to match the rest of
the desktop. It changes the vertical scrollbar to AUTOMATIC instead of
ALWAYS, so that it isn't shown when not needed.

-- dobey



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]