Re: [evolution-patches] [Mailer] Fix for 244058

[Parthasarathi Susarla <sparthasarathi novell com>]

Patch committed to head.

Cheers,
partha
On Wed, 2005-12-21 at 13:01 +0530, Johnny Jacob wrote:
> HI
> 
> Made the suggested changes. Attached the updated patch.
> 
> Thanks
> Johnny
> 
> On 12/20/05, Srinivasa Ragavan <sragavan novell com> wrote:
> > On Tue, 2005-12-20 at 18:44 +0530, Johnny Jacob wrote:
> > > Index: composer/e-msg-composer.c
> > > ===================================================================
> > > RCS file: /cvs/gnome/evolution/composer/e-msg-composer.c,v
> > > retrieving revision 1.526
> > > diff -u -p -r1.526 e-msg-composer.c
> > > --- composer/e-msg-composer.c   17 Dec 2005 14:14:07 -0000      1.526
> > > +++ composer/e-msg-composer.c   20 Dec 2005 13:12:37 -0000
> > > @@ -2505,6 +2505,22 @@ hdrs_changed_cb (EMsgComposerHdrs *hdrs,
> > >
> > >         composer = E_MSG_COMPOSER (data);
> > >
> > > +       char *temp;
> > > +
> > > +       composer = E_MSG_COMPOSER (data);
> > > +
> > > +       /* Check cc.entry. If hidden & not empty then show */
> > > +       if ( !e_msg_composer_get_view_cc (composer)) {
> > > +               temp = gtk_entry_get_text
> > > ( e_msg_composer_hdrs_get_cc_entry (hdrs));
> > > +               e_msg_composer_set_view_cc (composer, !(*temp ==
> > > '\0'));
> > Shouldnt the check be like temp && *temp to be simple and making sure
> > that it isnt null?
> > > +       }
> > > +
> > > +       /* Check bcc.entry  if hidden & not empty then show */
> > > +       if ( !e_msg_composer_get_view_bcc (composer)) {
> > > +               temp = gtk_entry_get_text
> > > ( e_msg_composer_hdrs_get_bcc_entry (hdrs));
> > > +               e_msg_composer_set_view_bcc (composer, !(*temp ==
> > > '\0'));
> > > +       }
> > > +
> > >         /* Mark the co
> >
> >
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches