Re: [evolution-patches] [Mailer] Fix for 244058

[Johnny Jacob <johnnyjacob gmail com>]

HI

Made the suggested changes. Attached the updated patch.

Thanks
Johnny

On 12/20/05, Srinivasa Ragavan <sragavan novell com> wrote:
> On Tue, 2005-12-20 at 18:44 +0530, Johnny Jacob wrote:
> > Index: composer/e-msg-composer.c
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/composer/e-msg-composer.c,v
> > retrieving revision 1.526
> > diff -u -p -r1.526 e-msg-composer.c
> > --- composer/e-msg-composer.c   17 Dec 2005 14:14:07 -0000      1.526
> > +++ composer/e-msg-composer.c   20 Dec 2005 13:12:37 -0000
> > @@ -2505,6 +2505,22 @@ hdrs_changed_cb (EMsgComposerHdrs *hdrs,
> >
> >         composer = E_MSG_COMPOSER (data);
> >
> > +       char *temp;
> > +
> > +       composer = E_MSG_COMPOSER (data);
> > +
> > +       /* Check cc.entry. If hidden & not empty then show */
> > +       if ( !e_msg_composer_get_view_cc (composer)) {
> > +               temp = gtk_entry_get_text
> > ( e_msg_composer_hdrs_get_cc_entry (hdrs));
> > +               e_msg_composer_set_view_cc (composer, !(*temp ==
> > '\0'));
> Shouldnt the check be like temp && *temp to be simple and making sure
> that it isnt null?
> > +       }
> > +
> > +       /* Check bcc.entry  if hidden & not empty then show */
> > +       if ( !e_msg_composer_get_view_bcc (composer)) {
> > +               temp = gtk_entry_get_text
> > ( e_msg_composer_hdrs_get_bcc_entry (hdrs));
> > +               e_msg_composer_set_view_bcc (composer, !(*temp ==
> > '\0'));
> > +       }
> > +
> >         /* Mark the co
>
>

Index: composer/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/composer/ChangeLog,v
retrieving revision 1.727
diff -u -p -r1.727 ChangeLog
--- composer/ChangeLog	17 Dec 2005 17:22:49 -0000	1.727
+++ composer/ChangeLog	21 Dec 2005 07:02:35 -0000
@@ -1,3 +1,9 @@
+2005-12-20  Johnny Jacob  <johnnyjacob gmail com>
+
+	Fixes Bug #244058
+	* e-msg-composer.c (hdrs_changed_cb) : Bcc, Cc fields, if hidden 
+	and not empty, then show.
+ 
 2005-12-17  Tor Lillqvist  <tml novell com>
 
 	* e-msg-composer.c
Index: composer/e-msg-composer.c
===================================================================
RCS file: /cvs/gnome/evolution/composer/e-msg-composer.c,v
retrieving revision 1.526
diff -u -p -r1.526 e-msg-composer.c
--- composer/e-msg-composer.c	17 Dec 2005 14:14:07 -0000	1.526
+++ composer/e-msg-composer.c	21 Dec 2005 07:03:40 -0000
@@ -2505,6 +2505,22 @@ hdrs_changed_cb (EMsgComposerHdrs *hdrs,
 	
 	composer = E_MSG_COMPOSER (data);
 	
+	char *temp;
+
+	composer = E_MSG_COMPOSER (data);
+
+       /* Check cc.entry. If hidden & not empty then show */
+	if ( !e_msg_composer_get_view_cc (composer)) {
+		temp = gtk_entry_get_text ( e_msg_composer_hdrs_get_cc_entry (hdrs));
+		e_msg_composer_set_view_cc (composer, *temp && temp);
+	}
+
+	/* Check bcc.entry  if hidden & not empty then show */
+	if ( !e_msg_composer_get_view_bcc (composer)) {
+		temp = gtk_entry_get_text ( e_msg_composer_hdrs_get_bcc_entry (hdrs));
+		e_msg_composer_set_view_bcc (composer, *temp && temp);
+	}
+
 	/* Mark the composer as changed so it prompts about unsaved changes on close */
 	e_msg_composer_set_changed (composer);
 }