[evolution-patches] patch for bug 324473

[jeff cai <Jeff Cai Sun COM>]

Hi,partha and all

When emae_signature_removed is called, the account editor has been
closed. 
Therefore combobox of emae->priv->signatures_dropdown in the line
"gtk_combo_box_get_model(emae->priv->signatures_dropdown)" is not valid at this
time. 
In fact, emae_signature_removed should not be called at all in this case. That
is to say, when account editor is closed, the handler "emae_signature_removed"
should be disconnected from the signal "signature_removed" which is done in
"emae_finalise". But I never see it is called.

I give a patch to make account editor destroyed.


? Evolution-Mail-common.c
? Evolution-Mail-common.lo
? Evolution-Mail-skels.c
? Evolution-Mail-skels.lo
? Evolution-Mail-stubs.c
? Evolution-Mail-stubs.lo
? Evolution-Mail.h
? Spell-common.lo
? Spell-skels.lo
? Spell-stubs.lo
? e-searching-tokenizer.lo
? em-account-editor.lo
? em-account-prefs.lo
? em-composer-prefs.lo
? em-composer-utils.lo
? em-config.lo
? em-event.lo
? em-filter-context.lo
? em-filter-editor.lo
? em-filter-folder-element.lo
? em-filter-rule.lo
? em-filter-source-element.lo
? em-folder-browser.lo
? em-folder-properties.lo
? em-folder-selection-button.lo
? em-folder-selection.lo
? em-folder-selector.lo
? em-folder-tree-model.lo
? em-folder-tree.lo
? em-folder-utils.lo
? em-folder-view.lo
? em-format-hook.lo
? em-format-html-display.lo
? em-format-html-print.lo
? em-format-html.lo
? em-format-quote.lo
? em-format.lo
? em-html-stream.lo
? em-icon-stream.lo
? em-inline-filter.lo
? em-junk-hook.lo
? em-mailer-prefs.lo
? em-marshal.lo
? em-menu.lo
? em-message-browser.lo
? em-migrate.lo
? em-popup.lo
? em-search-context.lo
? em-stripsig-filter.lo
? em-subscribe-editor.lo
? em-sync-stream.lo
? em-utils.lo
? em-vfolder-context.lo
? em-vfolder-editor.lo
? em-vfolder-rule.lo
? em-vfs-stream.lo
? evolution-mail-2.6.schemas
? libevolution-mail.la
? mail-autofilter.lo
? mail-component-factory.lo
? mail-component.lo
? mail-config-factory.lo
? mail-config.lo
? mail-crypto.lo
? mail-folder-cache.lo
? mail-mt.lo
? mail-ops.lo
? mail-send-recv.lo
? mail-session.lo
? mail-signature-editor.lo
? mail-tools.lo
? mail-vfolder.lo
? mail.error
? message-list.lo
? message-tag-editor.lo
? message-tag-followup.lo
? patch324473
? default/zh_CN/Makefile
? default/zh_CN/Makefile.in
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3751
diff -u -r1.3751 ChangeLog
--- ChangeLog	20 Dec 2005 10:06:39 -0000	1.3751
+++ ChangeLog	21 Dec 2005 02:48:04 -0000
@@ -1,3 +1,10 @@
+2005-12-21  Jeff Cai <jeff cai sun com>
+
+	** See bug 324473
+	* em-account-editor.c: (em_account_editor_construct):
+	delete reference to account editor to make sure be destroyed 
+	when it is closed.
+
 2005-12-20  Veerapuram Varadhan  <vvaradhan novell com>
 
 	Fixes #246256
Index: em-account-editor.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-account-editor.c,v
retrieving revision 1.37
diff -u -r1.37 em-account-editor.c
--- em-account-editor.c	18 Dec 2005 04:42:25 -0000	1.37
+++ em-account-editor.c	21 Dec 2005 02:48:05 -0000
@@ -2736,6 +2736,5 @@
 	e_config_set_target((EConfig *)ec, (EConfigTarget *)target);
 	emae->editor = e_config_create_window((EConfig *)ec, NULL, type==EMAE_NOTEBOOK?_("Account Editor"):_("Evolution Account Assistant"));
 
-	g_object_ref(emae);
 	g_signal_connect(emae->editor, "destroy", G_CALLBACK(emae_editor_destroyed), emae);
 }