[evolution-patches] fix for the bug #320101 [calendar]



hi,
  Have attached the fix for the bug. Return the list of email ids
entered and names.

thanks, Chenthill.
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2897
diff -u -p -u -p -r1.2897 ChangeLog
--- ChangeLog	20 Dec 2005 09:47:55 -0000	1.2897
+++ ChangeLog	20 Dec 2005 13:21:32 -0000
@@ -1,3 +1,11 @@
+2005-12-20  Chenthill Palanisamy  <pchenthill novell com>
+
+	Fixes #320101
+	* gui/e-select-names-editable.c:
+	(e_select_names_editable_get_emails),
+	(e_select_names_editable_get_names): Append the list of email ids
+	and names.
+
 2005-12-20  Veerapuram Varadhan	 <vvaradhan novell com>
 
 	Fixes #323125, #323126
Index: gui/e-select-names-editable.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-select-names-editable.c,v
retrieving revision 1.12
diff -u -p -u -p -r1.12 e-select-names-editable.c
--- gui/e-select-names-editable.c	24 Aug 2005 03:07:49 -0000	1.12
+++ gui/e-select-names-editable.c	20 Dec 2005 13:21:32 -0000
@@ -129,7 +129,7 @@ GList *
 e_select_names_editable_get_emails (ESelectNamesEditable *esne)
 {
 	EDestinationStore *destination_store;
-	GList *destinations;
+	GList *destinations, *l;
 	EDestination *destination;
 	GList *result = NULL;
 
@@ -140,24 +140,26 @@ e_select_names_editable_get_emails (ESel
 	if (!destinations)
 		return NULL;
 
-	destination = destinations->data;
-	if (e_destination_is_evolution_list (destination)) {	
-		const GList *list_dests, *l;
-
-		list_dests = e_destination_list_get_dests (destination);
-		for (l = list_dests; l != NULL; l = g_list_next (l)) {
-			result = g_list_append (result, g_strdup (e_destination_get_email (l->data)));
+	for (l = destinations; l != NULL; l = l->next) {
+		destination = l->data;
+		if (e_destination_is_evolution_list (destination)) {	
+			const GList *list_dests, *l;
+
+			list_dests = e_destination_list_get_dests (destination);
+			for (l = list_dests; l != NULL; l = g_list_next (l)) {
+				result = g_list_append (result, g_strdup (e_destination_get_email (l->data)));
+			}
+		} else {
+			/* check if the contact is contact list, it does not contain all the email ids  */
+			/* we dont expand it currently, TODO do we need to expand it by getting it from addressbook*/
+			if (e_contact_get (e_destination_get_contact (destination), E_CONTACT_IS_LIST)) {
+				/* If its a contact_list which is not expanded, it wont have a email id,
+				   so we can use the name as the email id */
+
+				result = g_list_append (result, g_strdup (e_destination_get_name (destination)));
+			} else
+				result = g_list_append (result, g_strdup (e_destination_get_email (destination)));
 		}
-	} else {
-		/* check if the contact is contact list, it does not contain all the email ids  */
-		/* we dont expand it currently, TODO do we need to expand it by getting it from addressbook*/
-		if (e_contact_get (e_destination_get_contact (destination), E_CONTACT_IS_LIST)) {
-			/* If its a contact_list which is not expanded, it wont have a email id,
-			   so we can use the name as the email id */
-
-			 result = g_list_append (result, g_strdup (e_destination_get_name (destination)));
-		} else
-			 result = g_list_append (result, g_strdup (e_destination_get_email (destination)));
 	}
 
 	g_list_free (destinations);
@@ -182,6 +184,7 @@ e_select_names_editable_get_name (ESelec
 
 	destination = destinations->data;
 	result = g_strdup (e_destination_get_name (destination));
+
 	g_list_free (destinations);
 	return result;
 }
@@ -201,18 +204,19 @@ e_select_names_editable_get_names (ESele
 	if (!destinations)
 		return NULL;
 
-	destination = destinations->data;	
-	if (e_destination_is_evolution_list (destination)) {
-		const GList *list_dests, *l;
-		
-		list_dests = e_destination_list_get_dests (destination);
-		for (l = list_dests; l != NULL; l = g_list_next (l)) {
-			result = g_list_append (result, g_strdup (e_destination_get_name (l->data)));
+	for (l = destinations; l != NULL; l = l->next) {
+		destination = l->data;	
+		if (e_destination_is_evolution_list (destination)) {
+			const GList *list_dests, *l;
+
+			list_dests = e_destination_list_get_dests (destination);
+			for (l = list_dests; l != NULL; l = g_list_next (l)) {
+				result = g_list_append (result, g_strdup (e_destination_get_name (l->data)));
+			}
+		} else {
+			result = g_list_append (result, g_strdup (e_destination_get_name (destination)));
 		}
-	} else {
-		result = g_list_append (result, g_strdup (e_destination_get_name (destination)));
 	}
-
 	g_list_free (destinations);
 
 	return result;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]