Re: [evolution-patches] [copy-tool plugin] Fix for bug #313430

[Not Zed <notzed ximian com>]

Hmm, it should probably check that the right selection is being cleared,
i.e. only clear if the clipboard buffer is being cleared.  The same
function is called for the primary selection too.

On Mon, 2005-08-22 at 14:27 +0530, Devashish Sharma wrote:
> Hi,
> 
> Made the changes, attaching the revised patch.
> 
> thanks
> devashish
> 
> On Mon, 2005-08-22 at 16:20 +0800, Not Zed wrote:
> > This cannot possibly make any difference:
> > 
> > On Mon, 2005-08-22 at 12:15 +0530, Devashish Sharma wrote:
> > >  {
> > >         g_free(address_uri);
> > > +       address_uri = NULL;
> > >         address_uri = g_strdup(t->uri);
> > 
> > 
> > The other part probably does though.
> > 
> > Also, your changelog entry is meaningless.  "fix for x", can be part of
> > the entry, but you have to say what you actually changed, and where you
> > did it.
> > 
-- 
adfa(evolution-2.4:20087): gtkhtml-WARNING **: cannot find icon:
'stock_insert-url' in gnome