Re: [evolution-patches] [copy-tool plugin] Fix for bug #313430

[Devashish Sharma <sdevashish novell com>]

Hi,

Made the changes, attaching the revised patch.

thanks
devashish

On Mon, 2005-08-22 at 16:20 +0800, Not Zed wrote:
> This cannot possibly make any difference:
> 
> On Mon, 2005-08-22 at 12:15 +0530, Devashish Sharma wrote:
> >  {
> >         g_free(address_uri);
> > +       address_uri = NULL;
> >         address_uri = g_strdup(t->uri);
> 
> 
> The other part probably does though.
> 
> Also, your changelog entry is meaningless.  "fix for x", can be part of
> the entry, but you have to say what you actually changed, and where you
> did it.
> 

Index: plugins/copy-tool/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/plugins/copy-tool/ChangeLog,v
retrieving revision 1.8
diff -u -p -r1.8 ChangeLog
--- plugins/copy-tool/ChangeLog	12 May 2005 04:27:37 -0000	1.8
+++ plugins/copy-tool/ChangeLog	22 Aug 2005 08:58:47 -0000
@@ -1,3 +1,11 @@
+2005-08-19  Devashish Sharma <sdevashish novell com>
+
+	* copy-tool.c (ct_selection_clear_event): Triple clicking to select a
+	contact raises the ct_selection_clear_event which flushes the copied
+	address.So, removed the part which was freeing the address, anyway the 
+	address	is getting freed before copying a new one.
+	Fix for Bug #313430
+
 2005-05-11  Not Zed  <NotZed Ximian com>
 
 	* Makefile.am: added built_sources/cleanfiles.
Index: plugins/copy-tool/copy-tool.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/copy-tool/copy-tool.c,v
retrieving revision 1.1
diff -u -p -r1.1 copy-tool.c
--- plugins/copy-tool/copy-tool.c	21 Oct 2004 08:39:32 -0000	1.1
+++ plugins/copy-tool/copy-tool.c	22 Aug 2005 08:58:48 -0000
@@ -74,8 +74,6 @@ ct_selection_clear_event(GtkWidget *widg
 {
 	printf("selection clear event\n");
 
-	g_free(address_uri);
-	address_uri = NULL;
 }
 
 int e_plugin_lib_enable(EPluginLib *ep, int enable);