Re: [evolution-patches] [calendar-plugins] some itip-formatter.c fixes

["Carsten Guenther" <Carsten Guenther scalix com>]

On Aug 19, 2005, at 8:46 AM, chen wrote:

> Apart from the patch sent, there are Unapproved and unnecessary  
> changes
> committed which does not solve anything.
>
> Why was the following changes made ? The following was to tell user  
> that
> the calendar could not be opened due to some error.
>
> @@ -270,11 +270,7 @@ cal_opened_cb (ECal *ecal, ECalendarStat
>
>         if (status != E_CALENDAR_STATUS_OK) {
>                 d(printf ("Failed opening itip formatter calendar '%s'
> during non-search opening\n", e_source_peek_name (source)));
> -               itip_view_add_lower_info_item_printf (ITIP_VIEW
> (pitip->view), ITIP_VIEW_INFO_ITEM_TYPE_WARNING,
> -                                                     "Failed to load
> the calendar '%s'", e_source_peek_name (source));
> -
>                 g_hash_table_remove (pitip->ecals[source_type],
> e_source_peek_uid (source));
> -
>                 return;
>         }
>
> @@ -379,11 +375,7 @@ find_cal_opened_cb (ECal *ecal, ECalenda
>                  * to find the item, this won't be cleared but the
>                  * selector might be shown */
>                 d(printf ("Failed opening itip formatter calendar '%s'
> during search opening... ", e_source_peek_name (source)));
> -               itip_view_add_lower_info_item_printf (ITIP_VIEW
> (pitip->view), ITIP_VIEW_INFO_ITEM_TYPE_WARNING,
> -                                                    "Failed to  
> load the
> calendar '%s'", e_source_peek_name (source));
> -
>                 g_hash_table_remove (pitip->ecals[source_type],
> e_source_peek_uid (source));
> -
>                 goto cleanup;
>         }

I have put back in the aboove two lines. I will open a bug later and  
provide another patch (should have done this anyways).

> As e_error_run would just return TRUE or FALSE, this not very much
> required.
>
> -                                       if (e_error_run (NULL,
> "org.gnome.itip-formatter:add-unknown-attendee", NULL) ==
> GTK_RESPONSE_YES) {
> +
> +                                       response = (e_error_run (NULL,
> "org.gnome.itip-formatter:add-unknown-attendee", NULL));
> +
> +

This was made to improve readability, you already have allocated the  
response variable, why not use it?

Carsten

> Can we revert these unwanted changes. Harish ?
>
> thanks, Chenthill.
>
> On Wed, 2005-08-17 at 23:29 -0700, Carsten Guenther wrote:
>
> > There was some really weird stuff in itip-formatter.c, like the
> > following statement:
> >
> > if ((response == e_error_run (NULL, "org.gnome.itip-formatter:add-
> > delegate", itip_strip_mailto (a->delfrom)), itip_strip_mailto (a-
> >
> > > value)) == GTK_RESPONSE_YES) {
> > ..
> > }
> > Attached patch fixes this and another location and gets rid of some
> > warnings.
>
>
> > OK to commit?
> >
> > Carsten
> >
> > _______________________________________________
> > evolution-patches mailing list
> > evolution-patches lists ximian com
> > http://lists.ximian.com/mailman/listinfo/evolution-patches
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches